Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape string literals before using them #47

Merged
merged 1 commit into from Jul 20, 2016
Merged

Unescape string literals before using them #47

merged 1 commit into from Jul 20, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jul 18, 2016

Pipeline rules use the same lexical structure as Java for string literals.

Before using the parsed string literals, we need to unescape them, removing double backslashes, otherwise the string will actually include two backslashes instead of one.

Fixes #46

@lennartkoopmann
Copy link
Member

@lennartkoopmann lennartkoopmann commented Jul 19, 2016

This fixed #45 for me.

Pipeline rules use the same lexical structure as Java for string literals.
Before using the parsed string literals, we need to unescape them, removing
double backslashes, otherwise the string will actually include two
backslashes instead of one.

Fixes #46
@kroepke kroepke force-pushed the issue-46 branch from c69393f to 95ac71a Jul 20, 2016
@kroepke
Copy link
Member

@kroepke kroepke commented Jul 20, 2016

rebased to current master, lgtm

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants