add optional prefix/suffix to set_fields functions #75
Conversation
| set_field("only_in", "new message", x); | ||
| set_fields({ multi: "new message" }, x); | ||
| set_field("has_source", has_field("source", x), x); | ||
| set_field(field: "removed_again", value: "foo", message: x); |
bernd
Aug 8, 2016
Member
Are the named values required now?
Are the named values required now?
kroepke
Aug 8, 2016
Author
Member
They are only if we want to set the optional message parameter. Leaving that out you can also omit the parameter names
Prefix and Suffix are "in between" the positional params, the parser does not yet try to match the parameter types.
They are only if we want to set the optional message parameter. Leaving that out you can also omit the parameter names
Prefix and Suffix are "in between" the positional params, the parser does not yet try to match the parameter types.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #74