Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional prefix/suffix to set_fields functions #75

Merged
merged 1 commit into from Aug 8, 2016
Merged

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Aug 3, 2016

fixes #74

@kroepke kroepke added this to the 1.1.0 milestone Aug 3, 2016
@bernd bernd self-assigned this Aug 8, 2016
set_field("only_in", "new message", x);
set_fields({ multi: "new message" }, x);
set_field("has_source", has_field("source", x), x);
set_field(field: "removed_again", value: "foo", message: x);

This comment has been minimized.

@bernd

bernd Aug 8, 2016
Member

Are the named values required now?

This comment has been minimized.

@kroepke

kroepke Aug 8, 2016
Author Member

They are only if we want to set the optional message parameter. Leaving that out you can also omit the parameter names
Prefix and Suffix are "in between" the positional params, the parser does not yet try to match the parameter types.

@bernd
Copy link
Member

@bernd bernd commented Aug 8, 2016

LGTM 👍

@bernd bernd merged commit c051191 into master Aug 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bernd bernd deleted the prefix_suffix_fields branch Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.