New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister PipelineInterpreter from event bus #79

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 12, 2016

Message decorators and the pipeline simulator create new instances of PipelineInterpreters that never get garbage collected, as they are still registered in the event bus.

These changes add a simple workaround for that. We should probably refactor the lifecycle of the PipelineInterpreter, but this is probably not the best time to do it.

Unregister PipelineInterpreter from event bus
Message decorators and the pipeline simulator create new instances of
PipelineInterpreters that never get garbage collected, as they are still
registered in the event bus.

These changes add a simple workaround for that. We should probably
refactor the lifecycle of the PipelineInterpreter, but this is probably
not the best time to do it.

@edmundoa edmundoa added this to the 1.1.0 milestone Aug 12, 2016

@bernd bernd self-assigned this Aug 16, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 16, 2016

LGTM 👍

@bernd bernd merged commit 944c7b9 into master Aug 16, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the unregister-event-bus branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment