Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exception instead of Error in migration #123

Merged
merged 1 commit into from Mar 20, 2019
Merged

Use exception instead of Error in migration #123

merged 1 commit into from Mar 20, 2019

Conversation

@kmerz
Copy link
Member

@kmerz kmerz commented Feb 1, 2019

Prior to this change, the migration used Error instead of an Exception
when the migration did find a matching LookupTable installation already.

This change will use ContentPackException instead so following migrations
can continue to work!

Also we will write the clusterConfig to avoid running into a already found content pack after every restart.

@kmerz kmerz added this to the 3.0.1 milestone Feb 1, 2019
@kmerz kmerz requested a review from bernd Feb 1, 2019
Prior to this change, the migration used Error instead of an Exception
when the migration did find a matching LookupTable installation already.

This change will use ContentPackException instead so following migrations
can continue to work!
@kmerz kmerz force-pushed the use-exception branch from 8ff579b to 62cc052 Feb 1, 2019
bernd
bernd approved these changes Mar 20, 2019
@bernd bernd merged commit 1a34c2c into master Mar 20, 2019
2 checks passed
@bernd bernd deleted the use-exception branch Mar 20, 2019
bernd added a commit that referenced this issue Mar 20, 2019
Prior to this change, the migration used Error instead of an Exception
when the migration did find a matching LookupTable installation already.

This change will use ContentPackException instead so following migrations
can continue to work!

(cherry picked from commit 1a34c2c)
kmerz added a commit that referenced this issue Mar 20, 2019
Use exception instead of Error in migration (#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants