Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default timezone on new LDAP users #1000

Closed
edmundoa opened this issue Feb 26, 2015 · 4 comments
Closed

Set default timezone on new LDAP users #1000

edmundoa opened this issue Feb 26, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Feb 26, 2015

New LDAP users haven't their timezone set, using UTC as default. It would be better to use something more meaningful as a default value, probably the admin user's timezone.

@kroepke
Copy link
Member

@kroepke kroepke commented Mar 3, 2015

Do they get UTC explicitly?
I think they should either get the app.conf default value or we should allow a more flexible mapping of ldap attributes. (Easiest solution would be the former, of course)

@kroepke kroepke added the users label Mar 3, 2015
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Mar 3, 2015

I was playing with it on 1.0.0 when I filled the issue and they do get UTC as default, maybe the behaviour changed at some point.

Reading the timezone from LDAP would be nice, but at the moment I think using the application's timezone would suffice.

@kroepke
Copy link
Member

@kroepke kroepke commented Mar 3, 2015

Agreed!
On Mar 3, 2015 11:57 AM, "Edmundo Alvarez" notifications@github.com wrote:

I was playing with it on 1.0.0 when I filled the issue and they do get UTC
as default, maybe the behaviour changed at some point.

Reading the timezone from LDAP would be nice, but at the moment I think
using the application's timezone would suffice.


Reply to this email directly or view it on GitHub
#1000 (comment)
.

@bernd bernd added this to the 1.2.0 milestone Aug 6, 2015
@kroepke kroepke modified the milestones: 1.x, 1.2.0 Sep 1, 2015
@bernd bernd added this to the 1.3.0 milestone Oct 27, 2015
bernd added a commit that referenced this issue Nov 11, 2015
@bernd
Copy link
Member

@bernd bernd commented Nov 11, 2015

Fixed in #1554

@bernd bernd closed this Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants