Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Receiving empty messages on AMQP GELF input will result in requeueing and inifinite message processing loop #1018
It seems that the GELF AMQP input will basicNack unhandled messages while procesing. On empty messages (where e.g. only an AMQP header is set) this will result in requeueing the same message. However this same message will subsequently be processed by the input plugin again and again resulting in a message loop.
Any GELF input requires a valid GELF message. Sending a GELF message with an empty body is an error.
I guess the problem here is that the
Running into the same error with the same message sounds wrong to me.
Hi Bernd, this is exactly what I mean. As the GELF AMQP plugin cannot enforce the format of the message that is sent by a publisher, this will lead to a re-processing of the message (in most cases). As an addition to just providing a flag whether or not to requeue, you could also write a qualified "warning" message to the system log (instead of just writing a full stack trace), like you do when a plugin fails or any other system event occurs.