New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams ignore floating point numbers when using numeric rules #1101

Closed
mmcguinn opened this Issue Apr 8, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mmcguinn

mmcguinn commented Apr 8, 2015

I set up a stream where one of the conditions was that the field 'cost' was greater than 0. I then sent messages that had a cost of 0.1. None of these messages went into the stream. I then tried sending message that had a cost of 1, all of which went into the stream. Finally, I sent messages that had a cost of 1.1, none of which went into the stream.

In summary:

stream rule is cost must be > 0
cost: 0.1 -> not accepted
cost: 1 -> accepted
cost: 1.1 -> not accepted

Are floating point values not accepted here? as far as I can tell float work everywhere else (graphs and statistics).

This is with version 1.0.1

@kroepke

This comment has been minimized.

Member

kroepke commented Apr 8, 2015

I think, without checking the code right now, that the field is indeed an
integer.

That needs to be corrected since it shouldn't break existing behavior.
Will schedule for 1.1.
On Apr 8, 2015 9:33 PM, "mmcguinn" notifications@github.com wrote:

I set up a stream where one of the conditions was that the field 'cost'
was greater than 0. I then sent messages that had a cost of 0.1. None of
these messages went into the stream. I then tried sending message that had
a cost of 1, all of which went into the stream. Finally, I sent messages
that had a cost of 1.1, none of which went into the stream.

In summary:

stream rule is cost must be > 0
cost: 0.1 -> not accepted
cost: 1 -> accepted
cost: 1.1 -> not accepted

Are floating point values not accepted here? as far as I can tell float
work everywhere else (graphs and statistics).

This is with version 1.0.1


Reply to this email directly or view it on GitHub
#1101.

@kroepke kroepke added this to the 1.1.0 milestone Apr 8, 2015

@kroepke kroepke added the bug label Apr 8, 2015

@bernd bernd self-assigned this May 24, 2015

bernd added a commit that referenced this issue May 24, 2015

Handle double values in greater/smaller stream matcher.
Before this, all values have been converted to ints.

Fixes #1101
@bernd

This comment has been minimized.

Member

bernd commented May 24, 2015

This has been fixed in #1178.

@bernd bernd closed this May 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment