Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlarmCallbacks are no longer compatible with v1.1(.1) #1221

Closed
lennartkoopmann opened this issue Jun 5, 2015 · 2 comments
Closed

AlarmCallbacks are no longer compatible with v1.1(.1) #1221

lennartkoopmann opened this issue Jun 5, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@lennartkoopmann
Copy link
Member

@lennartkoopmann lennartkoopmann commented Jun 5, 2015

Users noticed that for example the Slack plugin is no longer working with v1.1(.1):

java.lang.NoSuchMethodError: org.graylog2.plugin.alarms.AlertCondition.getSearchHits()Ljava/util/List;
at org.graylog2.alarmcallbacks.slack.SlackClient.buildPostParametersFromAlertCondition(SlackClient.java:163)
at org.graylog2.alarmcallbacks.slack.SlackClient.trigger(SlackClient.java:107)
at org.graylog2.alarmcallbacks.slack.SlackAlarmCallback.call(SlackAlarmCallback.java:58)
at org.graylog2.rest.resources.streams.alerts.StreamAlertReceiverResource.sendDummyAlert(StreamAlertReceiverResource.java:168)

Indeed that method was removed in bc83b85. A commit the same day (516f522) tried to "sustain plugin api backwards compatibility" but did not add the method back to the interface.

We will need to upload new alarm callback plugins that use the 1.1.2 plugin-interfaces after fixing this.

@lennartkoopmann lennartkoopmann added this to the 1.1.2 milestone Jun 5, 2015
@bassrock
Copy link

@bassrock bassrock commented Jun 5, 2015

👍

Loading

@lennartkoopmann lennartkoopmann self-assigned this Jun 5, 2015
@lennartkoopmann
Copy link
Member Author

@lennartkoopmann lennartkoopmann commented Jun 5, 2015

Adding note that we need to release new alarm callback plugins using the 1.1.2 plugin interfaces dependency after this.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants