Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Elasticsearch/OpenSearch cluster health summary on Indices page #13024

Merged

Conversation

supahgreg
Copy link
Contributor

@supahgreg supahgreg commented Jul 9, 2022

Description

This PR introduces support for showing a minimal version of IndexerClusterHealth, and uses that to provide a quick overview of ES/OS cluster health on System / Indices.

IndicesPage was also converted to a pure function to address a Reviewbot warning.

Motivation and Context

System / Indices is a natural place for a Graylog admin to start when looking for health/status info about the Elasticsearch/OpenSearch cluster, but thus far it's been necessary to click into a specific index set (or visit System / Overview) to get that info. This PR increases visibility of the ES/OS cluster's health.

This resolves #13017.

How Has This Been Tested?

Verified the minimal version of IndexerClusterHealth was displayed @ System / Indices, and the "full" version was displayed @ System / Overview.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bernd bernd requested a review from linuspahl July 11, 2022 08:59
@supahgreg supahgreg force-pushed the feature/cluster-health-on-indices-page branch from ac9d406 to 6fd0b72 Compare July 11, 2022 11:03
@supahgreg supahgreg force-pushed the feature/cluster-health-on-indices-page branch from a4d03b3 to 9f1af3f Compare July 12, 2022 00:45
@linuspahl linuspahl self-assigned this Jul 12, 2022
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good to me. Thank you once again!

I have a few smaller suggestions regarding the code style, but I will just implement them directly in a follow-up PR.

@linuspahl linuspahl merged commit 064ea8b into Graylog2:master Jul 13, 2022
@supahgreg supahgreg deleted the feature/cluster-health-on-indices-page branch July 13, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Elasticsearch/OpenSearch cluster health on index sets overview page
2 participants