New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles/user groups #1321

Closed
kroepke opened this Issue Jul 23, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Jul 23, 2015

In order to support a more usable permission model we need to implement roles to group permissions and assign them to users.

@kroepke kroepke changed the title from User groups to Roles/user groups Jul 23, 2015

@kroepke kroepke self-assigned this Jul 23, 2015

@kroepke kroepke added this to the 1.2.0 milestone Jul 23, 2015

@kroepke

This comment has been minimized.

Member

kroepke commented Jul 23, 2015

kroepke added a commit that referenced this issue Jul 23, 2015

initial support for roles and LDAP groups
- LDAP group mapping is incomplete and doesn't work in this commit yet
- roles CRUD API is complete
- Shiro support is complete
- no UI support yet

related to #1321 #951

kroepke added a commit that referenced this issue Jul 24, 2015

implement LDAP groups to role mapping
 - add /system/ldap/settings/groups endpoints for managing the mapping
 - correctly resolve a user's roles to permissions when retrieving the user (so that the web interface gets the correct set of permissions)
 - some cleanup regarding bindings
 - add new permissions for reading/editing ldap group mappings, which can be done independently of configuring ldap system settings
 - group mapping uses the objectid of roles, not their names, so they work correct after role renames

 issue #1321 #951

kroepke added a commit that referenced this issue Jul 24, 2015

include a user's roles in GET /user/{name} response
 - so we can list each user's roles in the overview

issue #1321 #951

kroepke added a commit that referenced this issue Aug 4, 2015

kroepke added a commit that referenced this issue Aug 4, 2015

adding roles to user classes, added description property to Role
issue #1321 #951

(cherry picked from commit 80de41d)

Conflicts:
	graylog2-server/src/main/java/org/graylog2/users/RoleImpl.java
	graylog2-shared/src/main/java/org/graylog2/shared/users/Role.java

kroepke added a commit that referenced this issue Aug 5, 2015

kroepke added a commit that referenced this issue Aug 5, 2015

make description in RoleResponse optional
add web interface service class

issue #1321 #951

kroepke added a commit that referenced this issue Aug 10, 2015

support updating roles in rest client
fix exception when using Optional.get()

issue #1321 #951

kroepke added a commit that referenced this issue Aug 10, 2015

add read only flag to roles
ensure the Reader and Admin roles are always present during start

 - reader role does not contain the user-specific permissions needed to edit and change the password of the current user, these need to be set during user creation in that entity
 - admin is simply "*"

both built-in roles cannot be edited/deleted or otherwise changed.

fixes missing description when creating a role

issue #1321 #951
@bernd

This comment has been minimized.

Member

bernd commented Aug 31, 2015

Closing this because it's done.

@bernd bernd closed this Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment