New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException in GelfChunkAggregator.checkForCompletion #1544

Closed
dheygere opened this Issue Nov 9, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@dheygere

dheygere commented Nov 9, 2015

We are using the latest docker container (1.2.2) and logging via GELF UDP on an Azure VM (A4 instance with 8 cores and 14Gb Ram). We modified the jvm heap size of the container to 2Gb.

The Graylog server log contains several NullPointerException:

ERROR [NettyTransport] Error on Input [GELF UDP/56388bfce4b0bbe8f228a458] (channel [id: 0xf9a00325, /0:0:0:0:0:0:0:0:12205])
java.lang.NullPointerException
      at org.graylog2.inputs.codecs.GelfChunkAggregator.checkForCompletion(GelfChunkAggregator.java:153)
      at org.graylog2.inputs.codecs.GelfChunkAggregator.addChunk(GelfChunkAggregator.java:91)
      at org.graylog2.plugin.inputs.transports.NettyTransport$MessageAggregationHandler.messageReceived(NettyTransport.java:297)
      at org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88)
      at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
      at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
      at org.jboss.netty.handler.traffic.AbstractTrafficShapingHandler.messageReceived(AbstractTrafficShapingHandler.java:718)
      at org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88)
      at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
      at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
      at org.jboss.netty.channel.SimpleChannelUpstreamHandler.messageReceived(SimpleChannelUpstreamHandler.java:124)
      at org.graylog2.plugin.inputs.util.PacketInformationDumper.messageReceived(PacketInformationDumper.java:73)
      at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
      at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
      at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
      at org.jboss.netty.channel.SimpleChannelUpstreamHandler.messageReceived(SimpleChannelUpstreamHandler.java:124)
      at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
      at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
      at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
      at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
      at org.jboss.netty.channel.socket.nio.NioDatagramWorker.read(NioDatagramWorker.java:98)
      at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)
      at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
      at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
      at org.jboss.netty.channel.socket.nio.NioDatagramWorker.run(NioDatagramWorker.java:343)
      at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
      at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
      at com.codahale.metrics.InstrumentedExecutorService$InstrumentedRunnable.run(InstrumentedExecutorService.java:176)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      at java.lang.Thread.run(Thread.java:745)

joschi added a commit that referenced this issue Nov 9, 2015

@dheygere

This comment has been minimized.

dheygere commented Nov 9, 2015

Wow, the fix was fast ! 👍
I wonder if a message with a null chunk can be valid though?

joschi added a commit that referenced this issue Nov 11, 2015

joschi added a commit that referenced this issue Nov 11, 2015

joschi added a commit that referenced this issue Nov 11, 2015

Fix NPE in GelfChunkAggregator#checkForCompletion()
Fixes #1544

(cherry picked from commit 33b17d8)

@joschi joschi closed this in 99d3e24 Nov 11, 2015

@bernd

This comment has been minimized.

Member

bernd commented Nov 11, 2015

This will be in the upcoming Graylog version 1.2.3. Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment