/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializing a blacklist filter (FilterDescription) leads to StackOverflowError #1641

Closed
joschi opened this Issue Dec 18, 2015 · 1 comment

Comments

Assignees

@dennisoelkers dennisoelkers

Labels
Projects
None yet
Milestone
  1.3.2
3 participants
@joschi @dennisoelkers @kroepke
@joschi
Contributor

joschi commented Dec 18, 2015

Jackson 2.6.3 and later (tested with Jackson 2.6.3, 2.6.4, and 2.7.0-rc1) in combination with MongoJack lead to a StackOverflowError when trying to deserialize a FilterDescription (including its child classes BlacklistIpMatcherCondition, BlacklistFieldEqualityCondition, and BlacklistPatternCondition) from the database.

Steps to reproduce:

$ curl -u admin:admin -i -H "Content-Type: application/json" -XPOST -d '{"type":"regex", "name":"Testfilter", "description":"test", "field_name": "message", "pattern": "posts"}' http://localhost:12900/filters/blacklist
$ curl -i -u admin:admin http://localhost:12900/filters/blacklist?pretty

@joschi joschi added bug infrastructure S1 P1 labels Dec 18, 2015

@joschi joschi added this to the 1.3.2 milestone Dec 18, 2015

joschi referenced this issue Dec 18, 2015

@dennisoelkers
Downgrade Jackson version to 2.6.2 because of bug. 
2.6.3 and onwards has issues deserializing polymorphic classes, which
breaks our blacklist filter.
Loading status checks…
e20fe76
@joschi

This comment has been minimized.

Sign in to view
Contributor

joschi commented Dec 18, 2015

Fixed in e20fe76.

@joschi joschi closed this Dec 18, 2015

@joschi joschi assigned dennisoelkers Dec 18, 2015

dennisoelkers added a commit that referenced this issue Dec 18, 2015

@dennisoelkers
Test proper deserialization of blacklist filters. 
Adding a test for the case described in #1641, as closed in
e20fe76.
8ce0c7c

dennisoelkers added a commit that referenced this issue Dec 18, 2015

@dennisoelkers
Test proper deserialization of blacklist filters. 
Adding a test for the case described in #1641, as closed in
e20fe76.

(cherry picked from commit 8ce0c7c)
174267e

@kroepke kroepke added the triaged label Sep 21, 2016

leusonmario pushed a commit to leusonmario/graylog2-server that referenced this issue Aug 2, 2017

@joschi @edmundoa
Merge pull request Graylog2#1641 from Graylog2/issue-1628 
Allow negative and empty values on numeric fields
(cherry picked from commit 5f9eb78aab6b2f496bd2caaf3dc3e29f9334502b)

(cherry picked from commit 4afce1d864e7cf8e605ef586675d5848b8b82898)
7143e93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment