Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing invalid input id to /system/inputs/{id} should not return 500 #1718

Closed
kroepke opened this issue Jan 25, 2016 · 0 comments
Closed

Passing invalid input id to /system/inputs/{id} should not return 500 #1718

kroepke opened this issue Jan 25, 2016 · 0 comments
Labels
Milestone

Comments

@kroepke
Copy link
Member

@kroepke kroepke commented Jan 25, 2016

GET http://localhost:12900/system/inputs/undefined returns 500 (Internal Server Error) because it doesn't catch the ObjectId conversion error.

This should return 404 instead to not cause callers to assume a hard error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants