Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graylog server does not properly close zlib/gzip streams. #1857

Closed
StephanErb opened this issue Feb 25, 2016 · 1 comment
Closed

Graylog server does not properly close zlib/gzip streams. #1857

StephanErb opened this issue Feb 25, 2016 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@StephanErb
Copy link

@StephanErb StephanErb commented Feb 25, 2016

As detailed in this article, InflaterInputStream and GZIPInputStream allocate native memory that is not freed until close() or when the finalizer runs.

It is therefore best to close() these streams explicitly. This is currently not the case in the Graylog code base for decompressZlib and decompressGzip.

It can therefore be the case, that the graylog server uses more memory than the configured heap size. This is a potential risk for production installation as the server might be killed due to out of memory conditions.

@joschi joschi self-assigned this Feb 25, 2016
joschi pushed a commit that referenced this issue Feb 25, 2016
@joschi
Copy link
Contributor

@joschi joschi commented Feb 25, 2016

@StephanErb Good catch. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants