New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort extractors no longer works in 2.0.0-4.beta.3 #2086

Closed
jhaar opened this Issue Apr 15, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@jhaar

jhaar commented Apr 15, 2016

Problem description

I had just discovered the sort extractor feature yesterday and was very happy to see it. However, I upgraded to .3 today and now I discover that when I try to re-order my syslog extractors (about 12 of them), I drag one down the list and it pops back up to where it was before.

One other thing. I think when you add a new extractor it shows up at the bottom? Well this one I just added showed up 2nd in the list - and I can't change the order. So I don't know if that indicates a separate/different problem

Steps to reproduce the problem

  1. ...

Environment

  • Graylog Version: graylog-server-2.0.0-4.beta.3.noarch
  • Elasticsearch Version:
  • MongoDB Version:
  • Operating System:
  • Browser version:
@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 15, 2016

Hi @jhaar,

I have been trying to reproduce the issue on the latest Firefox and Chrome, and it works fine for me. Could you provide some information about your browser/OS, and any error messages that may appear in your browser's developer tools?

Please also be aware that you need to drop the item inside the modal, specially if you are fast with the mouse :)

Thank you!

@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 15, 2016

I think I managed to reproduce this. In my case, when I sort the extractors they keep the position, but if I wait a few seconds without saving, they reset to the original order. Is that the behaviour you are seeing @jhaar?

@edmundoa edmundoa added bug web labels Apr 15, 2016

@edmundoa edmundoa added this to the 2.0.0 milestone Apr 15, 2016

@edmundoa edmundoa self-assigned this Apr 15, 2016

edmundoa added a commit that referenced this issue Apr 15, 2016

Keep sort extractors while editing
Avoid unnecessary re-renderings in the extractors page, which also helps
keeping the extractor order while editing it.

Fixes #2086
@edmundoa

This comment has been minimized.

Member

edmundoa commented Apr 15, 2016

There was indeed a bug in there that was resetting the extractor sort while editing it. I have made a PR to fix it.

Thank you for reporting this issue!

@mrfreezer

This comment has been minimized.

mrfreezer commented Apr 16, 2016

there is even more i think.

i witnessed them moving around in - for me - totally random order from second to second.
almost like the sort order changes depending on which extractor was used last.

just checked: yes behaviour is still there, 2.0.0-beta.3 that is.

@kroepke kroepke added S3 P3 labels Apr 18, 2016

dennisoelkers added a commit that referenced this issue Apr 19, 2016

Keep sort extractors while editing (#2088)
Avoid unnecessary re-renderings in the extractors page, which also helps
keeping the extractor order while editing it.

Fixes #2086

@kroepke kroepke added the triaged label Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment