Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit saved search #2285

Closed
hc4 opened this issue May 25, 2016 · 20 comments
Closed

Unable to edit saved search #2285

hc4 opened this issue May 25, 2016 · 20 comments
Labels

Comments

@hc4
Copy link
Contributor

@hc4 hc4 commented May 25, 2016

Problem description

If I modify search query and click "Update search criteria" - it says that criteria was updated, but actualy nothing happend. And if I click "search" after query modification, Update button disapears, and there is only button "Save" like for first search. And I can't save new query with old name.

Environment

  • Graylog Version:2.0.1
@kriegaex
Copy link

@kriegaex kriegaex commented Dec 16, 2016

This also drives me crazy. I can neither save searches which currently return no results nor edit/delete them if the result set is empty. This pollutes our namespace, having duplicates for search labels with/without typos, for identical searches with just different time frame etc. There should be a way to manage saved searches (rename, delete, edit) without the need to actually execute them and get a non-empty result.

@joschi
Copy link
Contributor

@joschi joschi commented Dec 16, 2016

@kriegaex Which version of Graylog are you using?

@kriegaex
Copy link

@kriegaex kriegaex commented Dec 19, 2016

The front-end says: graylog-web-interface v1.3.4 (0d67a80)

BTW, I am not the administrator, just a user. But I know the former.

@joschi
Copy link
Contributor

@joschi joschi commented Dec 19, 2016

@kriegaex I recommend upgrading to the latest stable version of Graylog (which is Graylog 2.1.2 at the time of writing).

@kriegaex
Copy link

@kriegaex kriegaex commented Dec 19, 2016

Well, @joschi, I know this is often a good idea, but I have very limited influence on that decision. Can you provide me with arguments as to why upgrading would be a good idea? Has my issue definitely been fixed in 2.1.2? This issue is listed as open.

@joschi
Copy link
Contributor

@joschi joschi commented Dec 19, 2016

@kriegaex See http://docs.graylog.org/en/2.1/pages/changelog.html for the list of changes since Graylog 1.3.4 and https://www.graylog.org/blog/ for a more "user-friendly" list.

The issue with being unable to delete saved searches with 0 search results was fixed in #2253.

@et304383
Copy link

@et304383 et304383 commented Jan 11, 2017

If I modify the search query I am no longer given the option to update a saved search. It changes the button to "Save Search Criteria"

Very cumbersome.

@burukuru
Copy link

@burukuru burukuru commented Jan 30, 2017

I think this is still happening in 2.1.3.
I click on a saved search, modify the criteria, click "Saved search > Update search criteria". Interface confirms that changes saved, but on page reload old criteria is still there.
If I click search after modifying the criteria, the "Saved search" button changes as described in by Eric. Saving results in an error.
Search in both cases has results.

@joschi
Copy link
Contributor

@joschi joschi commented Jan 30, 2017

@burukuru

I think this is still happening in 2.1.3.

That's why this issue hasn't been closed yet…

@msteelepmp
Copy link

@msteelepmp msteelepmp commented Jun 14, 2017

I can confirm this issue is still happening in 2.2.3+7adc951.
The work around is to save the search under a new name and then delete the old search.

@bernd bernd modified the milestone: 2.x Jun 23, 2017
@jothoma1
Copy link

@jothoma1 jothoma1 commented Sep 13, 2017

Bug still present on 2.3
Users are a bit lost as they thought there saved search were updated

@joschi
Copy link
Contributor

@joschi joschi commented Sep 13, 2017

@jothoma1 Why wouldn't it be present in Graylog 2.3.x? The issue hasn't been worked on…

@hc4
Copy link
Contributor Author

@hc4 hc4 commented Sep 13, 2017

+1 for fix to this issue.
Very annoying.

ps. sometimes bugs fixes, because of refactoring of some core components.

@jothoma1
Copy link

@jothoma1 jothoma1 commented Sep 13, 2017

@joschi yes, sorry for the confusion but i just saw this as my users complain about it

@laakkus
Copy link

@laakkus laakkus commented Mar 21, 2018

2.4.0 , the bug annoys still
have to do some c&p, delete old, new search with the changes, save with the same name.. REFRESH holdin shift.

@bernstein82
Copy link

@bernstein82 bernstein82 commented Apr 10, 2018

oh my, yet another broken oss project without enough maintainers that care...

@joschi
Copy link
Contributor

@joschi joschi commented Apr 10, 2018

@bernstein82 We're looking forward to your pull request to fix the issue. 👍

@iakko
Copy link

@iakko iakko commented Apr 19, 2018

Hello @joschi, is there an idea about when the issue would be fixed?

@xtruthx
Copy link

@xtruthx xtruthx commented Apr 20, 2018

Hi, to know when the fix will be available would be nice @bernstein82.

@bernstein82
Copy link

@bernstein82 bernstein82 commented Apr 20, 2018

thanks @dennisoelkers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.