Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem updating stream rule in cloned stream #2346

Closed
bernd opened this issue Jun 10, 2016 · 0 comments
Closed

Problem updating stream rule in cloned stream #2346

bernd opened this issue Jun 10, 2016 · 0 comments
Assignees
Milestone

Comments

@bernd
Copy link
Member

@bernd bernd commented Jun 10, 2016

Problem description

Updating a stream rule in a cloned stream does not work.

Steps to reproduce the problem

  1. Create stream with a stream rule
  2. Clone the stream
  3. Edit a rule in the cloned stream
  4. Press save
  5. See error:
{
  "type": "ApiError",
  "message": "Instantiation of [simple type, class org.graylog2.rest.resources.streams.rules.requests.CreateStreamRuleRequest] value failed (java.lang.NullPointerException): Null description\n at [Source: org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream@1a0edc22; line: 1, column: 60]"
}

Environment

  • Graylog Version: 2.1.0-SNAPSHOT (commit 5f7b43c)
@bernd bernd added the bug label Jun 10, 2016
@bernd bernd added this to the 2.1.0 milestone Jun 10, 2016
@joschi joschi added S4 P3 S3 and removed S4 labels Jun 13, 2016
@joschi joschi self-assigned this Aug 9, 2016
joschi pushed a commit that referenced this issue Aug 9, 2016
joschi pushed a commit that referenced this issue Aug 9, 2016
The "description" field of stream rules has to be nullable because otherwise
legacy stream rules with no description cannot be edited anymore.

Refs #2244, fixes #2346
@bernd bernd closed this in #2646 Aug 10, 2016
bernd added a commit that referenced this issue Aug 10, 2016
* Add stream rule description when cloning streams
* Make CreateStreamRuleRequest#description() nullable
  The "description" field of stream rules has to be nullable because otherwise
  legacy stream rules with no description cannot be edited anymore.

Refs #2244 
Fixes #2346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants