/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error on slash in query #2372

Closed
sjoerdmulder opened this Issue Jun 17, 2016 · 1 comment

Comments

Assignees

@edmundoa edmundoa

Labels
P1 S3 bug triaged
Projects
None yet
Milestone
  2.1.0
4 participants
@sjoerdmulder @dennisoelkers @kroepke @edmundoa
@sjoerdmulder

sjoerdmulder commented Jun 17, 2016

Problem description

When searching something with a forward-slash / but that is not escaped, the web ui keeps hanging in a loading... state. I would expect malformed syntax feedback.

Steps to reproduce the problem

  1. Access the following url on a graylog instance: /search?rangetype=relative&fields=message%2Csource&width=1879&highlightMessage=&relative=300&q=bla%3A%2Ffoo

Environment

  • Graylog Version: 2.0.2
  • Elasticsearch Version: 2.3.3
  • MongoDB Version: 3.0.10
  • Operating System: Ubuntu 14.04
  • Browser version: Chrome 51
@sjoerdmulder

This comment has been minimized.

Sign in to view

sjoerdmulder commented Jun 17, 2016

Additional request. Would be great if the frontend shows that there was a 500 error instead of hanging in Loading... Now i had to find out using Dev-Tools / Firebug what the issue was.

@dennisoelkers dennisoelkers self-assigned this Jun 17, 2016

@dennisoelkers dennisoelkers added this to the 2.0.3 milestone Jun 17, 2016

@dennisoelkers dennisoelkers added the bug label Jun 17, 2016

@dennisoelkers dennisoelkers modified the milestones: 2.0.3, 2.0.4 Jun 21, 2016

@kroepke kroepke added S3 P1 labels Jun 27, 2016

@kroepke kroepke modified the milestones: 2.1.0, 2.0.4 Jun 27, 2016

@edmundoa edmundoa assigned edmundoa and unassigned dennisoelkers Jul 4, 2016

edmundoa added a commit that referenced this issue Jul 4, 2016

@edmundoa
Report syntax error if search query contains slash 
When the search query contains an unescaped slash, calling to
`generateParseException()` throws a NullPointerException. We solve it by
catching the exception and let the normal program flow to continue, which
at that point will return the syntax error.

Fixes #2372
Loading status checks…
fb4fcd7

@edmundoa edmundoa referenced this issue Jul 4, 2016

Merged

Report syntax error when search query contains unescaped slash #2450

edmundoa added a commit that referenced this issue Jul 4, 2016

@edmundoa
Report syntax error if search query contains slash 
When the search query contains an unescaped slash, calling to
`generateParseException()` throws a NullPointerException. We solve it by
catching the exception and let the normal program flow to continue, which
at that point will return the syntax error.

Fixes #2372
Loading status checks…
453c391

@joschi joschi closed this in #2450 Jul 11, 2016

joschi added a commit that referenced this issue Jul 11, 2016

@edmundoa @joschi
Report syntax error when search query contains unescaped slash (#2450) 
When the search query contains an unescaped slash, calling to
`generateParseException()` throws a NullPointerException. We solve it by
catching the exception and let the normal program flow to continue, which
at that point will return the syntax error.

Fixes #2372
Loading status checks…
9219da1

@edmundoa edmundoa referenced this issue Jul 20, 2016

Closed

Search with incorrect escape (/ vs \) can cause search to hang #2506

@kroepke kroepke added the triaged label Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment