Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user preferred timezone not saved #2393

Closed
jalogisch opened this issue Jun 21, 2016 · 4 comments
Closed

user preferred timezone not saved #2393

jalogisch opened this issue Jun 21, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@jalogisch
Copy link
Contributor

@jalogisch jalogisch commented Jun 21, 2016

Problem description

if you create a user and set the timezone from UTC to something else and update the user the message "user has updated" was shown in green bar, and it is displayed on the page.

But after reload or leaving the side it is switched back to UTC

Steps to reproduce the problem

  1. create user
  2. set timezone to something other than etc
  3. "update user"
  4. reload the page

Environment

  • Graylog Version: 2.0.3 (OVA)
@edmundoa edmundoa self-assigned this Jun 21, 2016
@edmundoa edmundoa added this to the 2.0.4 milestone Jun 21, 2016
@edmundoa edmundoa added bug web labels Jun 21, 2016
@joschi
Copy link
Contributor

@joschi joschi commented Jun 21, 2016

I can reproduce this neither in Graylog 2.0.3, nor on current master (2.1.0-SNAPSHOT).

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 21, 2016

It took me a while to reproduce it, apparently it only happens for some time zones in the etc section. This is the error message in the server logs:

2016-06-21 18:25:48,636 ERROR: org.graylog2.shared.rest.resources.RestResource - Invalid timezone 'Etc/EST', ignoring it for user new.
@joschi
Copy link
Contributor

@joschi joschi commented Jun 21, 2016

The correct one according to http://joda-time.sourceforge.net/timezones.html would be EST instead of Etc/EST.

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 21, 2016

Also regarding https://en.wikipedia.org/wiki/List_of_tz_database_time_zones. Currently we store all time-zones that don't belong to an area into Etc.

edmundoa added a commit that referenced this issue Jun 21, 2016
Adding Etc is incorrect and fails when parsint the zone in the server.
Instead we are adding an unclassified section for organisational purposes,
where we can place all time zones without area.

The area is now removed from those entries in the dropdown and will not
be send to the server.

Fixes #2393
@kroepke kroepke added S3 P3 labels Jun 27, 2016
@kroepke kroepke modified the milestones: 2.1.0, 2.0.4 Jun 27, 2016
joschi added a commit that referenced this issue Jun 29, 2016
* Reformat TimezoneSelect

Also use more accurate names for area, and location variables.
https://en.wikipedia.org/wiki/Tz_database#Names_of_time_zones

* Do not add Etc area to time zones without area

Adding Etc is incorrect and fails when parsint the zone in the server.
Instead we are adding an unclassified section for organisational purposes,
where we can place all time zones without area.

The area is now removed from those entries in the dropdown and will not
be send to the server.

Fixes #2393
@joschi joschi closed this in 3565815 Jun 29, 2016
@kroepke kroepke added the triaged label Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants