Skip to content

/ graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More lenient PluginLoader Version checks during pre-release #2462

Closed
kroepke opened this issue Jul 6, 2016 · 0 comments
Closed

More lenient PluginLoader Version checks during pre-release #2462

kroepke opened this issue Jul 6, 2016 · 0 comments
Assignees
@bernd
Labels
infrastructure
Milestone
2.1.0

Comments

@kroepke
Copy link
Member

@kroepke kroepke commented Jul 6, 2016

The plugin loading mechanism is currently very strict about plugins' required server versions.

During pre-release this creates unnecessary work updating plugin metadata all the time, because we cannot simply leave them on the next release version (e.g. server is 2.1.0-alpha.2-SNAPSHOT but plugins require 2.1.0).

As long as the server is strict when it is not in a pre-release version itself, I cannot see any immediate problems this would cause.
Essentially the server should do the following:

  • Check its own version if it is pre-release.
  • If yes, take its version without pre-release and compare plugin's required version as it does not (greaterThanOrEqualTo)
  • If no, take its version as it is and compare to plugin's required version.

Does anyone see any problems with this approch?
@bernd bernd modified the milestones: 2.2.0, 2.1.0 Jul 26, 2016
@bernd bernd self-assigned this Jul 27, 2016
bernd added a commit that referenced this issue Jul 27, 2016
@bernd
Make version comparison more lenient with pre-release versions
Loading status checks…
a2453fa 
Use the normal version without pre-release and build suffixes to compare
against the other when this a pre-release version.

Makes plugin loading work in a 2.1.0-beta.1 server where the plugin
requires 2.1.0.

Fixes #2462
@bernd bernd mentioned this issue Jul 27, 2016
Merged
@joschi joschi closed this in #2548 Jul 28, 2016
joschi added a commit that referenced this issue Jul 28, 2016
@bernd @joschi
Make version comparison more lenient with pre-release versions (#2548)
Loading status checks…
cc935d5 
Use the normal version without pre-release and build suffixes to compare
against the other when this a pre-release version.

Makes plugin loading work in a 2.1.0-beta.1 server where the plugin
requires 2.1.0.

Fixes #2462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernd bernd

Labels
infrastructure
Projects
None yet
Milestone
2.1.0
Linked pull requests

Successfully merging a pull request may close this issue.

Make version comparison more lenient with pre-release versions
2 participants
@bernd @kroepke
You can’t perform that action at this time.