Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only use named captures in Grok extractor #2500

Merged
merged 3 commits into from Jul 19, 2016
Merged

Conversation

bernd
Copy link
Member

@bernd bernd commented Jul 19, 2016

Update to the latest version of our java-grok port which adds support for this via upstream.

The option is disabled by default.

Fixes #1486

Example screenshots:

screenshot from 2016-07-19 16 12 54
screenshot from 2016-07-19 16 12 36

Update to the latest version of our java-grok port which adds support
for this via upstream.

The option is disabled by default.

Fixes #1486
</dependency>
<dependency>
<groupId>com.github.tony19</groupId>
<artifactId>named-regexp</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this dependency used for? It's also already a transitive dependency of org.graylog2.repackaged:grok:0.1.6-graylog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grok extractor test didn't run at one point without this. But I guess that was some local issue. Works now.

@joschi joschi self-assigned this Jul 19, 2016
@joschi
Copy link
Contributor

joschi commented Jul 19, 2016

LGTM. 👍

@joschi joschi merged commit 13f42b3 into master Jul 19, 2016
@joschi joschi deleted the issue-1486 branch July 19, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants