New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Admin Page broken, when having many roles assinges to one or more users #2526

Closed
schlitzered opened this Issue Jul 25, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@schlitzered

schlitzered commented Jul 25, 2016

Problem description

when having many roles assigned to a single user, it is no longer possible to reach the "Delete" or the "Edit" button via the user admin page in the Web interface. this is because all roles are listed in the role column, and the "Delete" and "Edit" buttons are simply not visible anymore.

Steps to reproduce the problem

  1. create many roles
  2. assign the roles to a single user, until the "$URI/system/users"
  3. visit the systems/user page
  4. you wont be able to reach the Delete or Edit buttons

Environment

  • Graylog Version: 2.0.3
  • Elasticsearch Version: 2.3.3
  • MongoDB Version: 3.2
  • Operating System: CentOS 7
  • Browser version: Firefox 47.0

@edmundoa edmundoa added bug web labels Jul 25, 2016

@edmundoa edmundoa added this to the 2.1.0 milestone Jul 25, 2016

@jfachal

This comment has been minimized.

jfachal commented Jul 26, 2016

The problem already exists from prior versions of Graylog (e.g. graylog-web-interface v1.3.4)

@kroepke kroepke self-assigned this Jul 26, 2016

kroepke added a commit that referenced this issue Jul 26, 2016

display session information, fix usability in user list, editing users
 - use better overflow when users have many roles, fixes #2526
 - ignore non-updatable properties in ChangeUserRequest fixes #2528
 - show session information in the user list fixes #2540

edmundoa added a commit that referenced this issue Aug 1, 2016

display session information, fix usability in user list, editing users (
#2541)

* display session information, fix usability in user list, editing users

 - use better overflow when users have many roles, fixes #2526
 - ignore non-updatable properties in ChangeUserRequest fixes #2528
 - show session information in the user list fixes #2540

* move inline styles into separate component css file

* check for permissions when rendering edit user form

in order to allow reader users to change their details we need to avoid redirecting to a page they cannot see
also add new permission for changing authentication settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment