Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload fires new request without checking if there is an existing one #2799

Closed
bernd opened this issue Sep 8, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@bernd
Copy link
Member

@bernd bernd commented Sep 8, 2016

Expected Behavior

The live reload should wait for a response before executing another search request to avoid overloading the server and Elasticsearch cluster.

Current Behavior

The live reload fires new search requests against the server according to the live reload interval even if a previous request didn't return yet. (i.e. caused by an overloaded Elasticsearch cluster or a high latency network connection to the Graylog server)

The following screenshot shows an example of this behavior.

image

Possible Solution

  • The client code should only issue a new search request if the previous one has returned
  • It should also ensure to wait according to the selected live reload interval before running the next request

Steps to Reproduce (for bugs)

  1. Enable live reload with a search query that takes longer than the selected live reload interval
  2. Open the network tab in the developer console
  3. See lots of pending search requests

Your Environment

  • Graylog Version: 2.1.1-SNAPSHOT+6e974b0
  • Browser version: 53.0.2785.101
@bernd bernd added the bug label Sep 8, 2016
@bernd bernd added this to the 2.1.1 milestone Sep 8, 2016
@dennisoelkers dennisoelkers self-assigned this Sep 9, 2016
@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Sep 9, 2016

We can solve it similar to #2712. Search is using some really old school code though, so I am gonna check how hard that's gonna be :)

dennisoelkers added a commit that referenced this issue Sep 9, 2016
Fixes #2799.
dennisoelkers added a commit that referenced this issue Sep 9, 2016
Fixes #2799.
edmundoa added a commit that referenced this issue Sep 12, 2016
@edmundoa edmundoa closed this in e2482ee Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants