New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with the same message ID are only shown once #2801

Closed
bernd opened this Issue Sep 9, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@bernd
Member

bernd commented Sep 9, 2016

Expected Behavior

If you have two messages in your system which have the same message ID, both of them should be shown in the search result.

Having two messages with the same message ID sounds wrong, but than can happen if you restore an index.

Current Behavior

We are currently using the message ID as a key for HTML elements. If two messages with the same message ID show up in the search result, react decides to only show the first of the two messages with the same ID.

image

Possible Solution

Include the index name in the key to make it unique.

Steps to Reproduce (for bugs)

  1. Send a message to Graylog
  2. Backup the index that contains the message
  3. Restore the index with a different index name
  4. Search for the message

Your Environment

  • Graylog Version: Graylog 2.1.1-SNAPSHOT+20d4b11

@bernd bernd added the bug label Sep 9, 2016

@joschi joschi added the web label Sep 9, 2016

@edmundoa edmundoa added this to the 2.1.1 milestone Sep 9, 2016

@edmundoa edmundoa self-assigned this Sep 9, 2016

edmundoa added a commit that referenced this issue Sep 9, 2016

Use index and message_id as message identifier
This avoids hiding duplicated messages in the search results after
restoring an archive.

Fixes #2801

edmundoa added a commit that referenced this issue Sep 9, 2016

Use index and message_id as message identifier
This avoids hiding duplicated messages in the search results after
restoring an archive.

Fixes #2801

dennisoelkers added a commit that referenced this issue Sep 9, 2016

Use index and message_id as message identifier (#2804)
This avoids hiding duplicated messages in the search results after
restoring an archive.

Fixes #2801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment