Skip to content

/ graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValidatorProvider a Singleton #3019

Closed
kroepke opened this issue Nov 2, 2016 · 1 comment
Closed

Make ValidatorProvider a Singleton #3019

kroepke opened this issue Nov 2, 2016 · 1 comment
Assignees
@joschi @edmundoa
Labels
backport
Milestone
2.1.2

Comments

@kroepke
Copy link
Member

@kroepke kroepke commented Nov 2, 2016

backport of #2864
@kroepke kroepke added the backport label Nov 2, 2016
@kroepke kroepke added this to the 2.1.2 milestone Nov 2, 2016
joschi pushed a commit that referenced this issue Nov 2, 2016
@bernd Jochen Schalanda
Make ValidatorProvider a Singleton
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
617b227 
The Validator instance creation is quite expensive. Making this a
Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs
per second to 2 GCs per second when running a load test of the collector
registration endpoint.

Closes #3019

(cherry picked from commit b82ca3e)
@joschi joschi mentioned this issue Nov 2, 2016
Merged
@joschi joschi self-assigned this Nov 2, 2016
@joschi joschi added the in progress label Nov 2, 2016
kroepke added a commit that referenced this issue Nov 2, 2016
@joschi @kroepke
Make ValidatorProvider a Singleton (#3038)
Loading status checks…
6b891a9 
The Validator instance creation is quite expensive. Making this a
Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs
per second to 2 GCs per second when running a load test of the collector
registration endpoint.

Closes #3019

(cherry picked from commit b82ca3e)
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Nov 2, 2016

Closed in 6b891a9
@edmundoa edmundoa closed this Nov 2, 2016
@ghost ghost assigned edmundoa Nov 2, 2016
@ghost ghost removed the in progress label Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joschi joschi

@edmundoa edmundoa

Labels
backport
Projects
None yet
Milestone
2.1.2
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@joschi @kroepke @edmundoa