New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ValidatorProvider a Singleton #3019

Closed
kroepke opened this Issue Nov 2, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@kroepke
Member

kroepke commented Nov 2, 2016

backport of #2864

@kroepke kroepke added the backport label Nov 2, 2016

@kroepke kroepke added this to the 2.1.2 milestone Nov 2, 2016

joschi added a commit that referenced this issue Nov 2, 2016

Make ValidatorProvider a Singleton
The Validator instance creation is quite expensive. Making this a
Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs
per second to 2 GCs per second when running a load test of the collector
registration endpoint.

Closes #3019

(cherry picked from commit b82ca3e)

@joschi joschi self-assigned this Nov 2, 2016

@joschi joschi added the in progress label Nov 2, 2016

kroepke added a commit that referenced this issue Nov 2, 2016

Make ValidatorProvider a Singleton (#3038)
The Validator instance creation is quite expensive. Making this a
Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs
per second to 2 GCs per second when running a load test of the collector
registration endpoint.

Closes #3019

(cherry picked from commit b82ca3e)
@edmundoa

This comment has been minimized.

Member

edmundoa commented Nov 2, 2016

Closed in 6b891a9

@edmundoa edmundoa closed this Nov 2, 2016

@wafflebot wafflebot bot removed the in progress label Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment