Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index set ui fixes #3203

Merged
merged 2 commits into from Dec 14, 2016
Merged

Index set ui fixes #3203

merged 2 commits into from Dec 14, 2016

Conversation

bernd
Copy link
Member

@bernd bernd commented Dec 14, 2016

  • Sort index sets by title, not by date
  • Do not show the rotation/retention form for non-writable index sets

@bernd bernd added this to the 2.2.0 milestone Dec 14, 2016
@@ -120,7 +120,7 @@ protected MongoIndexSetService(JacksonDBCollection<IndexSetConfig, ObjectId> col
final DBQuery.Query query = DBQuery.or(idQuery.toArray(new DBQuery.Query[0]));

return ImmutableList.copyOf(collection.find(query)
.sort(DBSort.desc("creation_date"))
.sort(DBSort.asc("title"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we could remove the index on creation_date (although it doesn't hurt either).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just leave it. Maybe we need it in the future... 😄

@joschi joschi self-assigned this Dec 14, 2016
@joschi joschi merged commit 1261a80 into master Dec 14, 2016
@joschi joschi deleted the index-set-ui-fixes branch December 14, 2016 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants