Adapt grace period to latest changes in alerts #3346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is still not possible to mute alerts, we are keeping the grace period and updating the way it works:
Instead of calculating the grace period using the
triggered_at
time, we are changing it to useresolved_at
. That means that the grace period will prevent to trigger a new alert once that alert is marked as resolved, helping to minimize the noise if a condition check is fluctuating too much.Refs #3178