/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input should stay stopped after "Edit input" #3479

Closed
HolgerOpenSource opened this Issue Feb 10, 2017 · 2 comments

Comments

Assignees

@joschi joschi

Labels
Projects
None yet
Milestone
  2.3.0
5 participants
@HolgerOpenSource @joschi @billmurrin @jalogisch @dennisoelkers
@HolgerOpenSource

HolgerOpenSource commented Feb 10, 2017

Manually stopped inputs are started again after we changed input parameters with "Edit input".

Expected Behavior

Input should stay in stopped state after edit input.

Current Behavior

Input starts automatically after saving the changes in input definition.

Possible Solution

Change code.

Steps to Reproduce (for bugs)

  1. stop input
  2. edit input (change for instance the port number)
  3. save changed input
  4. input ist now in started state

Context

Sometime we manually stop inputs to avoid overloading of Graylog during certain time frames. Manually stopped inputs must only start again when we do it manually.

Your Environment

Versions:

  • Graylog 2.1.2
  • elasticsearch 2.3.5
  • mongoDB 3.2.1
  • Linux SLES 11
  • Browser Firefox ESR 45.2.0

@jalogisch jalogisch added feature bug triaged and removed feature labels Feb 13, 2017

@jalogisch jalogisch modified the milestones: 2.2.x, 2.2.1 Feb 13, 2017

@joschi

This comment has been minimized.

Sign in to view
Contributor

joschi commented Feb 16, 2017 •
edited

Refs #967 and duplicate of graylog-labs/graylog2-web-interface#1131.

@dennisoelkers dennisoelkers modified the milestones: 2.2.2, 2.2.1 Feb 20, 2017

@dennisoelkers dennisoelkers modified the milestones: 2.3.0, 2.2.2 Mar 2, 2017

@billmurrin

This comment has been minimized.

Sign in to view
Contributor

billmurrin commented May 12, 2017

I wanted to solicit feedback from you guys on how you wanted to implement this. I don't mind helping code it (would be a fun project for me to learn more about under the hood), but I don't want to do it on my own without feedback on how you guys want it implemented in the system?

@joschi joschi self-assigned this May 15, 2017

joschi added a commit that referenced this issue May 15, 2017

@joschi
Don't start stopped inputs after updating them 
Fixes #3479
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
cad2f2c

@joschi joschi referenced this issue May 15, 2017

Merged

Don't start stopped inputs after updating them #3824

@wafflebot wafflebot bot added the in progress label May 15, 2017

@kroepke kroepke closed this in #3824 May 16, 2017

kroepke added a commit that referenced this issue May 16, 2017

@joschi @kroepke
Don't start stopped inputs after updating them (#3824) 
* Don't start stopped inputs after updating them

Fixes #3479

* Simplify start conditions in InputEventListener
Loading status checks…
6e5d70e

@wafflebot wafflebot bot removed the in progress label May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment