Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts - make stateful notification an option #3511

Closed
jalogisch opened this issue Feb 16, 2017 · 8 comments
Closed

alerts - make stateful notification an option #3511

jalogisch opened this issue Feb 16, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@jalogisch
Copy link
Member

@jalogisch jalogisch commented Feb 16, 2017

Expected Behavior

It should be possible for the user to enable the old notification behavior - because this new way of notification breaks the default from 2.X Version

Current Behavior

If someone updates to the Version 2.2.0 he can't work with any kind of workflow or environment around Graylog that had used the alarming feature that returns every minute the alarm.

Possible Solution

Make the stateful notification an option and or make it possible to return to the old behavior of getting a notification as long as the condition is found.

Context

The new stateful notification is a breaking change.

People used the old way of notification in other ways that we - the developers did not even think of.

Taking Graylog2/graylog-support#9 and this https://community.graylog.org/t/alert-conditions/80 we are facing two possible workflows that we did not see during development.

Additional none of the Testers of Beta or RC Version has such a workflow and could had stopped us.

Your Environment

  • Graylog Version: 2.2.0
@edmundoa edmundoa self-assigned this Feb 17, 2017
@hezor
Copy link

@hezor hezor commented Feb 18, 2017

This is good news. We too have the kind of alerts that won't work properly with the stateful behavior. Any chance this option could be included in 2.2.1?

@gruselglatz
Copy link

@gruselglatz gruselglatz commented Feb 20, 2017

It is also important for our Workflow, that we can bound one or more condition/s and notification/s to each other. Because we need different notifications on different events in the same stream. At the moment we have to create a new stream for every new condition/notification relationship.

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Feb 20, 2017

@gruselglatz: Is this related to stateful alerting or a different feature? I think what you mean is coupling alert notifications to alert conditions, is that correct?

@gruselglatz
Copy link

@gruselglatz gruselglatz commented Feb 20, 2017

@dennisoelkers yes, like the old behaviour

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Feb 20, 2017

@gruselglatz the old behaviour was not like that, alert conditions and notifications were bounded to a stream, just like they are in now.

@gruselglatz
Copy link

@gruselglatz gruselglatz commented Feb 20, 2017

@edmundoa ok sorry, but you know what my point is? i only want to link notifications to a certain condition, that i can create more use cases in one stream

@jalogisch jalogisch added the feature label Feb 20, 2017
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Feb 20, 2017

@gruselglatz yes, I know. That's one of the future improvements that may come to alerting, but so far we didn't have enough time to do it. If you want to discuss that, feel free to open another issue, let's keep this issue on stateful notification, please 🙂

edmundoa added a commit that referenced this issue Feb 22, 2017
edmundoa added a commit that referenced this issue Feb 22, 2017
When user sets the `repeat_notifications` flag in the alert condition,
resend the notifications regardless of the alert state. The alert will
continue to have a state anyway, and all sent notifications will be
visible in the web interface on the alerts detail page.

Refs #3511
@florianpopp florianpopp added the triaged label Feb 23, 2017
dennisoelkers added a commit that referenced this issue Feb 24, 2017
* Add option to repeat notifications

Refs #3511

* Resend notifications when user sets the flag

When user sets the `repeat_notifications` flag in the alert condition,
resend the notifications regardless of the alert state. The alert will
continue to have a state anyway, and all sent notifications will be
visible in the web interface on the alerts detail page.

Refs #3511

* Add repetition setting to alert summaries

* Add repetition setting to alert timeline

* Add date to notification histories

- Sort histories by creation datetime
- Add the time were the notification was sent, to help seeing the order
and also that the attempts sending the notification are different

* Do not include ms in history datetime

* Add license header

* Rename variable

* Fix import

* Use moment to sort notifications by date
dennisoelkers added a commit that referenced this issue Feb 24, 2017
* Add option to repeat notifications

Refs #3511

* Resend notifications when user sets the flag

When user sets the `repeat_notifications` flag in the alert condition,
resend the notifications regardless of the alert state. The alert will
continue to have a state anyway, and all sent notifications will be
visible in the web interface on the alerts detail page.

Refs #3511

* Add repetition setting to alert summaries

* Add repetition setting to alert timeline

* Add date to notification histories

- Sort histories by creation datetime
- Add the time were the notification was sent, to help seeing the order
and also that the attempts sending the notification are different

* Do not include ms in history datetime

* Add license header

* Rename variable

* Fix import

* Use moment to sort notifications by date

(cherry picked from commit 003bea9)
joschi added a commit that referenced this issue Mar 2, 2017
* Add option to repeat notifications

Refs #3511

* Resend notifications when user sets the flag

When user sets the `repeat_notifications` flag in the alert condition,
resend the notifications regardless of the alert state. The alert will
continue to have a state anyway, and all sent notifications will be
visible in the web interface on the alerts detail page.

Refs #3511

* Add repetition setting to alert summaries

* Add repetition setting to alert timeline

* Add date to notification histories

- Sort histories by creation datetime
- Add the time were the notification was sent, to help seeing the order
and also that the attempts sending the notification are different

* Do not include ms in history datetime

* Add license header

* Rename variable

* Fix import

* Use moment to sort notifications by date

(cherry picked from commit 003bea9)
@dennisoelkers dennisoelkers added this to the 2.2.2 milestone Mar 2, 2017
@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Mar 2, 2017

Fixed in #3535 & #3544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.