/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination on the Manage alert conditions page is not working #3528

Closed
crodrigocs opened this Issue Feb 20, 2017 · 0 comments

Comments

Assignees

@dennisoelkers dennisoelkers

@joschi joschi

Labels
Projects
None yet
Milestone
  2.2.2
3 participants
@crodrigocs @dennisoelkers @joschi
@crodrigocs

crodrigocs commented Feb 20, 2017

If more than 10 alert conditions are added, pagination kicks in. When I try to go to the next page, it jumps to the next condition and won't let me go any further.

Expected Behavior

When clicking the next page it should jump to the next 10 conditions.

Current Behavior

When clicking the next page, it jumps to the next condition.

Example:
Conditions 1 to 10 are being displayed. When I click the next page button, conditions 2 to 11 are displayed (instead of conditions 11 to 20) and there's no way to move further.

Possible Solution

Change the pagination behavior to what it should be or remove pagination altogether.

Steps to Reproduce (for bugs)

  1. Add more than 10 alert conditions
  2. Go to the Alerts page and click "Manage Conditions"
  3. Click on the next page number or > or >>

Your Environment

  • Graylog Version: 2.2.1
  • Elasticsearch Version: 2.4.2
  • Operating System: Ubuntu 14.04.5 LTS
  • Browser version: Chrome 56.0.2924.87 / IE 11.0.9600.18499

@dennisoelkers dennisoelkers self-assigned this Feb 21, 2017

@dennisoelkers dennisoelkers added this to the 2.2.2 milestone Feb 21, 2017

@dennisoelkers dennisoelkers added bug web labels Feb 21, 2017

dennisoelkers added a commit that referenced this issue Feb 21, 2017

@dennisoelkers
Fixing slicing of alert conditions in pagination. 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528.
Verified
This commit was signed with a verified signature.
@dennisoelkers dennisoelkers Dennis Oelkers
GPG key ID: 26B2C114209DC497 Learn about signing commits
Loading status checks…
3ef7059

@dennisoelkers dennisoelkers referenced this issue Feb 21, 2017

Merged

Fixing slicing of alert conditions in pagination. #3529

3 of 9 tasks complete

@dennisoelkers dennisoelkers added the in progress label Feb 21, 2017

@joschi joschi closed this in #3529 Feb 23, 2017

@wafflebot wafflebot bot assigned joschi Feb 23, 2017

@wafflebot wafflebot bot removed the in progress label Feb 23, 2017

joschi added a commit that referenced this issue Feb 23, 2017

@dennisoelkers @joschi
Fixing slicing of alert conditions in pagination. (#3529) 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
Loading status checks…
0e25b82

joschi added a commit that referenced this issue Feb 23, 2017

@dennisoelkers @joschi
Fixing slicing of alert conditions in pagination. (#3529) 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
7f70f15

joschi added a commit that referenced this issue Feb 23, 2017

@dennisoelkers @joschi
Fixing slicing of alert conditions in pagination. (#3529) 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
427fb7e

@joschi joschi referenced this issue Feb 23, 2017

Merged

Fixing slicing of alert conditions in pagination #3541

edmundoa added a commit that referenced this issue Feb 23, 2017

@joschi @edmundoa
Fixing slicing of alert conditions in pagination. (#3529) (#3541) 
Before this change, the slice of alert conditions shown in the paginated
view was calculated incorrectly.

Fixes #3528
(cherry picked from commit 0e25b82)
Loading status checks…
76ede1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment