Fix DateHistogram-related functionality in Searches class #3806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searches.DateHistogramInterval
was usingjava.time.Period
to define its intervals and tried to convert them to milliseconds in theSearches.DateHistogramInterval#getMillis()
method which triggered an exception ("Cannot convert to Seconds as this period contains years and years vary in length") when using a period with variable length such as month, quarter, or year.This change changes the DateHistogram-related methods in
Searches
to use the equivalent interval from theorg.elasticsearch.search.aggregations.bucket.histogram.DateHistogramInterval
class to perform aggregations.