Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reloading error states when not showing overview pages #3834

Closed
kroepke opened this issue May 16, 2017 · 0 comments · Fixed by #3839
Closed

Avoid reloading error states when not showing overview pages #3834

kroepke opened this issue May 16, 2017 · 0 comments · Fixed by #3839
Assignees
@kroepke
Labels
bug triaged
Projects
Lookup Tables
Milestone
2.3.0

Comments

@kroepke
Copy link
Member

kroepke commented May 16, 2017

Lookup tables and related entities still reload the error states of the last displayed page, even though a detail component is shown.

This leads to unnecessary traffic (potentially push timer down to list components to avoid conditional logic in the page)
@kroepke kroepke created this issue from a note in Lookup Tables (TODO) May 16, 2017
@kroepke kroepke added this to the 2.3.0 milestone May 16, 2017
@kroepke kroepke mentioned this issue May 17, 2017
Merged
@kroepke kroepke moved this from TODO to In Progress in Lookup Tables May 17, 2017
kroepke added a commit that referenced this issue May 17, 2017
@kroepke
refactor error states timer handling to prevent unnecessary reloads
169f1bd 
previously the page component always reloaded the error states even though
they were not used at all.

now the component only starts the timer for the overview pages

fixes #3834
@kroepke kroepke mentioned this issue May 17, 2017
Merged
@ghost ghost assigned kroepke May 17, 2017
@ghost ghost added the in progress label May 17, 2017
edmundoa pushed a commit that referenced this issue May 17, 2017
@kroepke @edmundoa
Don't reload errorstates on pages that don't need them (#3839)
225157b 
* refactor error states timer handling to prevent unnecessary reloads

previously the page component always reloaded the error states even though
they were not used at all.

now the component only starts the timer for the overview pages

fixes #3834

* make sure we don't accidentally leak background tasks

before scheduling a new interval make sure there's nothing running anymore
@ghost ghost removed the in progress label May 17, 2017
@bernd bernd moved this from In Progress to Done in Lookup Tables Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroepke kroepke

Labels
bug triaged
Projects
No open projects
Lookup Tables
Done
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Don't reload errorstates on pages that don't need them Graylog2/graylog2-server
1 participant
@kroepke