New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reloading error states when not showing overview pages #3834

Closed
kroepke opened this Issue May 16, 2017 · 0 comments

Comments

Projects
1 participant
@kroepke
Member

kroepke commented May 16, 2017

Lookup tables and related entities still reload the error states of the last displayed page, even though a detail component is shown.

This leads to unnecessary traffic (potentially push timer down to list components to avoid conditional logic in the page)

@kroepke kroepke created this issue from a note in Lookup Tables (TODO) May 16, 2017

@kroepke kroepke added this to the 2.3.0 milestone May 16, 2017

@kroepke kroepke moved this from TODO to In Progress in Lookup Tables May 17, 2017

kroepke added a commit that referenced this issue May 17, 2017

refactor error states timer handling to prevent unnecessary reloads
previously the page component always reloaded the error states even though
they were not used at all.

now the component only starts the timer for the overview pages

fixes #3834

@wafflebot wafflebot bot added the in progress label May 17, 2017

edmundoa added a commit that referenced this issue May 17, 2017

Don't reload errorstates on pages that don't need them (#3839)
* refactor error states timer handling to prevent unnecessary reloads

previously the page component always reloaded the error states even though
they were not used at all.

now the component only starts the timer for the overview pages

fixes #3834

* make sure we don't accidentally leak background tasks

before scheduling a new interval make sure there's nothing running anymore

@wafflebot wafflebot bot removed the in progress label May 17, 2017

@bernd bernd moved this from In Progress to Done in Lookup Tables Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment