Add support for updating extractors in InputService #3910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
InputService#deleteExtractor()
followed byInputService#addExtractor()
,which also emits the
InputUpdated
event twice, theInputService#updateExtractor()
methodreplaces the extractor in the embedded document in the "inputs" collection in MongoDB and
only emits the
InputUpdated
event once, which hopefully resolves the race condition describedin #3903.
Fixes #3903