New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users timezone is reset to UTC after adding roles #3918

Closed
jalogisch opened this Issue Jun 16, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@jalogisch
Member

jalogisch commented Jun 16, 2017

Expected Behavior

Adding roles to ldap auth users should not change the timezone of the users.

Current Behavior

When adding roles to Users that are authenticated via LDAP the timezone for this user is set to UTC.

Steps to Reproduce (for bugs)

  1. A newly logged in LDAP user is set with the correct timezone which is configured in the server.conf file.
  2. While editing the User's Streams and Dashboards permissions, the timezone remains correct.
  3. As soon as roles are added to the user and the Update role button is clicked, the timezone is automatically changed to UT

Your Environment

  • Graylog Version: 2.1.3

@jalogisch jalogisch added the ldap label Jun 16, 2017

@bernd bernd added the to-verify label Jun 19, 2017

@bernd bernd added this to the 2.3.0 milestone Jun 19, 2017

@joschi joschi added bug triaged users and removed ldap to-verify labels Jun 21, 2017

@joschi

This comment has been minimized.

Contributor

joschi commented Jun 21, 2017

I could verify that problem, although it has nothing to do with LDAP.

The problem occurs for every user, no matter how the account was created.

Clicking on the "Update role" button in the Graylog web interface (System / Authentication / Users / Edit User) will send an empty user to the Graylog REST API. The other way round, clicking on the "Update user" button, is also broken and sends an empty roles list to the Graylog REST API.

@bernd bernd self-assigned this Jun 27, 2017

bernd added a commit that referenced this issue Jun 27, 2017

Always send a complete user object when updating a user or role
Previously, updating the user data sent a null roles field and updating
a role sent only the list of roles.

Remove now unused UsersStore#updateRoles().

Fixes #3918

@wafflebot wafflebot bot added the in progress label Jun 27, 2017

@joschi joschi closed this in #3942 Jun 27, 2017

@wafflebot wafflebot bot removed the in progress label Jun 27, 2017

joschi added a commit that referenced this issue Jun 27, 2017

Always send a complete user object when updating a user or role (#3942)
Previously, updating the user data sent a null roles field and updating
a role sent only the list of roles.

Remove now unused UsersStore#updateRoles().

Fixes #3918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment