Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Tables: Allow case-insensitive lookups #3961

Closed
lennartkoopmann opened this issue Jul 1, 2017 · 1 comment
Closed

Lookup Tables: Allow case-insensitive lookups #3961

lennartkoopmann opened this issue Jul 1, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@lennartkoopmann
Copy link
Member

@lennartkoopmann lennartkoopmann commented Jul 1, 2017

In a lookup table lookup it would be great if one could specify if the key should be handled case-insensitive or not.

My specific use-case: MAC address lookups. Some systems will send them with lowercase characters and some will uppercase them. Right now I am uppercasing them in the CSV and then applying uppercase() in the pipeline lookup to work around this.

"mac","station"
"82:2A:A8:07:4C:8D", "Home Main"
"2C:30:33:A5:8D:94", "Home Extender"
@bernd bernd self-assigned this Jul 3, 2017
@bernd bernd added this to the 2.3.0 milestone Jul 3, 2017
@bernd
Copy link
Member

@bernd bernd commented Jul 3, 2017

@lennartkoopmann We talked about this and will implement it for each data adapter where it makes sense and not with a generic config option for all data adapters. There will be data adapters where it does not make sense or isn't possible because the backend does not support it. (e.g. maxmind)

For 2.3 we will implement it for the CSV data adapter.

bernd added a commit that referenced this issue Jul 3, 2017
@ghost ghost added the in progress label Jul 3, 2017
@kroepke kroepke closed this in #3971 Jul 4, 2017
@ghost ghost removed the in progress label Jul 4, 2017
kroepke added a commit that referenced this issue Jul 4, 2017
* Add case-insensitive lookup config option to CSVFileDataAdapter

Closes #3961

* Use locale for toLowerCase to make forbidden-apis happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants