New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search result cannot highlighting #4101

Closed
xiewei308 opened this Issue Aug 22, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@xiewei308

xiewei308 commented Aug 22, 2017

Hello,

i got a problem with the "search result cannot highlighting".
The parameter was set to true in
/etc/graylog/server/server.conf(allow_highlighting = true)

Environment

Graylog Version: 2.3.0
Elasticsearch Version: 5.5.1
MongoDB Version: 3.4.6
Operating System: CentOS release 6.5 (Final)
Browser version: Chrome 60.0.3112.101 (64-bit)

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 22, 2017

@xiewei308 Please provide more details about the problem, such as the full error message and the logs of your Graylog and Elasticsearch nodes.

@dennisoelkers dennisoelkers self-assigned this Aug 22, 2017

@dennisoelkers dennisoelkers added the bug label Aug 22, 2017

dennisoelkers added a commit that referenced this issue Aug 22, 2017

Adding back search term highlighting.
During the switch from an ES node client to an HTTP client, code
relevant for parsing the highlighting information contained in the
search response was removed. This PR is adding it back.

Fixes #4101

@dennisoelkers dennisoelkers referenced this issue Aug 22, 2017

Merged

Adding back search term highlighting. #4103

4 of 9 tasks complete
@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Aug 22, 2017

Thanks for reporting this, @xiewei308. We have prepared a fix for this issue (#4103) and will include it in the next version (2.3.1) which will be released very soon.

@joschi joschi closed this in #4103 Aug 22, 2017

joschi added a commit that referenced this issue Aug 22, 2017

Add back search term highlighting (#4103)
During the switch from an ES node client to an HTTP client, code relevant for parsing the highlighting information contained in the search response was removed.

Fixes #4101

@joschi joschi added this to the 2.3.1 milestone Aug 22, 2017

joschi added a commit that referenced this issue Aug 24, 2017

Add back search term highlighting
During the switch from an ES node client to an HTTP client, code relevant for parsing the highlighting information contained in the search response was removed.

Fixes #4101

(cherry picked from commit 9c844a9)

bernd added a commit that referenced this issue Aug 24, 2017

Add back search term highlighting (#4108)
* Add back search term highlighting

During the switch from an ES node client to an HTTP client, code relevant for parsing the highlighting information contained in the search response was removed.

Fixes #4101

(cherry picked from commit 9c844a9)

* Add missing import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment