Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram zoom does not submit query when alt-modifier is used #4214

Closed
dennisoelkers opened this issue Oct 6, 2017 · 0 comments
Closed

Histogram zoom does not submit query when alt-modifier is used #4214

dennisoelkers opened this issue Oct 6, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Oct 6, 2017

Expected Behavior

When a selection on the histogram of the search result page is made, holding the alt-key when releasing the mouse automatically submitted the search query with the selected time range in the past.

Current Behavior

When holding the alt-key when making a selection, the absolute time range is entered, but the search query is not submitted automatically. Instead a stack trace is logged:

Rickshaw.Graph.Graylog2Selector.js:138 Uncaught ReferenceError: submitSearch is not defined
    at HTMLDivElement.complete (Rickshaw.Graph.Graylog2Selector.js:138)
    at done (effect.js:1419)
    at HTMLDivElement.cleanup (effect.js:1414)
    at Function.dequeue (vendor.js:51395)
    at HTMLDivElement.opt.complete (vendor.js:54163)
    at fire (vendor.js:50565)
    at Object.fireWith [as resolveWith] (vendor.js:50677)
    at tick (vendor.js:54035)
    at jQuery.fx.tick (vendor.js:54324)

Possible Solution

Steps to Reproduce (for bugs)

  1. Go to search page
  2. Hold alt-key while making a selection in the histogram

Context

Your Environment

  • Graylog Version: 3.0.0-SNAPSHOT
  • Elasticsearch Version:
  • MongoDB Version:
  • Operating System:
  • Browser version:
@dennisoelkers dennisoelkers added this to the 2.4.0 milestone Oct 6, 2017
kroepke added a commit that referenced this issue Oct 13, 2017
the old jquery code could submit the search form directly when the alt key was pressed.
ever since moving to react this was broken because the code cannot submit the form anymore.
this removes the useless code to avoid a javascript error

fixes #4214
@ghost ghost assigned kroepke Oct 13, 2017
@ghost ghost added the in progress label Oct 13, 2017
@joschi joschi closed this in #4243 Oct 13, 2017
joschi added a commit that referenced this issue Oct 13, 2017
The old jQuery code could submit the search form directly when the alt key was pressed.
Ever since moving to react this was broken because the code cannot submit the form anymore.

This commit removes the useless code to avoid a JavaScript error

Fixes #4214
@ghost ghost removed the in progress label Oct 13, 2017
joschi pushed a commit that referenced this issue Oct 13, 2017
The old jQuery code could submit the search form directly when the alt key was pressed.
Ever since moving to react this was broken because the code cannot submit the form anymore.

This commit removes the useless code to avoid a JavaScript error

Fixes #4214

(cherry picked from commit b8fec02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.