New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong spacing with new field analyzer buttons #4230

Closed
bernd opened this Issue Oct 10, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@bernd
Member

bernd commented Oct 10, 2017

Expected Behavior

There should be consistent spacing between the field analyzer widget buttons.

Current Behavior

After #4219 went it, there is no spacing between the "Add to dashboard" and "Customize" buttons in the field analyzer widgets.

QuickValues:
image

Chart:
image

Possible Solution

I guess we want to use a ButtonGroup wrapper component to get consistent spacing.

Steps to Reproduce (for bugs)

  1. Create QuickValues widget on the search page
  2. Create Chart widget on the search page
  3. Create map widget on the search page

Your Environment

  • Graylog Version: 3.0.0-SNAPSHOT (a99ea1d)
  • Browser version: 61.0.3163.100

@bernd bernd added the bug label Oct 10, 2017

@bernd bernd added this to the 2.4.0 milestone Oct 10, 2017

@joschi

This comment has been minimized.

Contributor

joschi commented Oct 10, 2017

@bernd I think that was intentional by @lennartkoopmann.

At least I read it that way in #4219 (comment)

The change to a close icon makes it stand out more and also saves real-estate. A margin to the left helps to identify it quickly and avoids accidental pressing of it.

@bernd

This comment has been minimized.

Member

bernd commented Oct 10, 2017

@joschi @lennartkoopmann If it was intentional, the "Customize" and "Add to dashboard" buttons should at least be grouped like before.

image

Now it looks like there is a missing margin.

@joschi joschi removed their assignment Oct 10, 2017

@lennartkoopmann

This comment has been minimized.

Member

lennartkoopmann commented Oct 11, 2017

You are right, the previous implementation looked a little different with regards to the borders of the two buttons. I guess the ButtonGroup styling got messed up by an inline div that I added.

I’m okay with moving this out of 2.4 if it’s not an easy fix.

@bernd bernd modified the milestones: 2.4.0, 3.0.0 Oct 13, 2017

@jalogisch jalogisch added the triaged label Oct 16, 2017

@edmundoa edmundoa self-assigned this Oct 23, 2017

edmundoa added a commit that referenced this issue Oct 24, 2017

@bernd bernd closed this in f09054a Oct 24, 2017

bernd added a commit that referenced this issue Oct 24, 2017

Improvements in unified analyzer menus (#4280)
* Fix styling of unified analyzer buttons

Fixes #4230

* Open analyzer menus to the left

Dropdown menus on the unified analyzer menus open currently to the right, but
they are very close to the edge of the window and will be cropped. This
commit changes that by opening menus to the left.

(cherry picked from commit f09054a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment