New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp field to search query through quick values does not work #4288

Closed
edmundoa opened this Issue Oct 25, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@edmundoa
Member

edmundoa commented Oct 25, 2017

Expected Behavior

Using the "add to query" button in quick values to add a timestamp field should add the right date time to the search bar.

Current Behavior

Using the "add to query" button in quick values to add a timestamp field adds "Invalid date" to the search bar.

Steps to Reproduce (for bugs)

  1. Run quick values analyzer on timestamp field
  2. Add one of the values to the query by using the "add to query" button
  3. Observe that no date or timestamp was added, but "Invalid date"

Your Environment

  • Graylog Version: Graylog 3.0.0-SNAPSHOT (aada4c6). I could not reproduce it in two 2.4.0 setups
  • Elasticsearch Version: 5.6.2

@edmundoa edmundoa added the bug label Oct 25, 2017

@bernd bernd added this to the 2.4.0 milestone Oct 25, 2017

@jalogisch jalogisch added the triaged label Nov 6, 2017

@kroepke kroepke self-assigned this Dec 15, 2017

@kroepke

This comment has been minimized.

Member

kroepke commented Dec 15, 2017

The issue here is that the QuickvaluesVisualization is not properly displaying formatted timestamps like the message table does, but simply displays the unix timestamp.

Adding that back to the query fails, because the search store has special handling for the timestamp field.

kroepke added a commit that referenced this issue Dec 15, 2017

when displaying quick values for the timestamp field convert unix tim…
…e to formatted date

otherwise the search store will end up searching for the unix timestamp which is not supported

fixes #4288

@wafflebot wafflebot bot added the in progress label Dec 15, 2017

@bernd

This comment has been minimized.

Member

bernd commented Dec 18, 2017

Moving to 3.0.0 milestone.

@bernd bernd modified the milestones: 2.4.0, 3.0.0 Dec 18, 2017

edmundoa added a commit that referenced this issue Dec 18, 2017

Convert timestamp quickvalues to formatted date (#4423)
* when displaying quick values for the timestamp field convert unix time to formatted date

otherwise the search store will end up searching for the unix timestamp which is not supported

fixes #4288

* respect timezones when stringifying

extract repeated code into function

@wafflebot wafflebot bot removed the in progress label Dec 18, 2017

bernd added a commit that referenced this issue Jan 24, 2018

Convert timestamp quickvalues to formatted date (#4423)
* when displaying quick values for the timestamp field convert unix time to formatted date

otherwise the search store will end up searching for the unix timestamp which is not supported

fixes #4288

* respect timezones when stringifying

extract repeated code into function

(cherry picked from commit b4af02b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment