Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve behaviour when stacking field on quick values fails #4289

Closed
edmundoa opened this issue Oct 25, 2017 · 0 comments
Closed

Improve behaviour when stacking field on quick values fails #4289

edmundoa opened this issue Oct 25, 2017 · 0 comments
Assignees
@bernd
Labels
blocker If not finished by release date, the release will be postponed. bug triaged
Milestone
2.4.0

Comments

@edmundoa
Copy link
Contributor

Stacking fields on quick values is not supported in ES 2, but there is no easy way of disabling the controls in that case. When trying to stack a field in ES 2, we end up with the quick values component stuck in a loading state and an error notification showing up, which is quite confusing.

Expected Behavior

Capture errors when stacking fields in quick values and show an error message in the div. At least we should update the component state, to avoid that it keeps on that loading state.

Current Behavior

The component stays in a broken state until the configuration changes or the quick values analyzer is dismissed and added again.

Steps to Reproduce (for bugs)

  1. Use ES 2
  2. Calculate quick values for a field
  3. Stack another field in the quick values configuration
  4. See the component spin until the configuration changes or quick values are dismissed

Your Environment

  • Graylog Version: 2.4.0-beta.1
  • Elasticsearch Version: ES 2.x
@edmundoa edmundoa added the bug label Oct 25, 2017
@bernd bernd added this to the 2.4.0 milestone Oct 25, 2017
@jalogisch jalogisch added triaged blocker If not finished by release date, the release will be postponed. labels Nov 6, 2017
@bernd bernd self-assigned this Nov 6, 2017
bernd added a commit that referenced this issue Nov 7, 2017
@bernd
Disable loading state in case of an error
8087ce3 
If the QuickValues HTTP request fails, reset the loading state so the
user is able to change settings and try again.

Fixes #4289
@bernd bernd mentioned this issue Nov 7, 2017
Merged
@ghost ghost added the in progress label Nov 7, 2017
@ghost ghost removed the in progress label Nov 7, 2017
edmundoa pushed a commit that referenced this issue Nov 7, 2017
@bernd @edmundoa
Improve robustness of QuickValues with stacked fields (#4322)
4775212 
* Add elasticsearch version to cluster stats

* Reset to default options when analyzing a new message field

* Disable loading state in case of an error

If the QuickValues HTTP request fails, reset the loading state so the
user is able to change settings and try again.

Fixes #4289

* Disable stacked fields feature when running with ES < 5
edmundoa pushed a commit that referenced this issue Nov 7, 2017
@bernd
Improve robustness of QuickValues with stacked fields (#4322)
fd8b54b 
* Add elasticsearch version to cluster stats

* Reset to default options when analyzing a new message field

* Disable loading state in case of an error

If the QuickValues HTTP request fails, reset the loading state so the
user is able to change settings and try again.

Fixes #4289

* Disable stacked fields feature when running with ES < 5

(cherry picked from commit 4775212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernd bernd

Labels
blocker If not finished by release date, the release will be postponed. bug triaged
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@bernd @jalogisch @edmundoa