New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Quick Values stacked value separation #4309

Closed
lennartkoopmann opened this Issue Nov 2, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@lennartkoopmann
Member

lennartkoopmann commented Nov 2, 2017

Currently, the stacked values in the quick values widget can be hard to separate if at least one of the values is a value with multiple words like, for example, a sentence because the separator is just a thin dash in the same font, contrast and color as the stacked values.

I suggest we color the dash red and make it bold. Let's see how that looks like. :)

@lennartkoopmann lennartkoopmann added this to the 2.4.0 milestone Nov 2, 2017

bernd added a commit that referenced this issue Nov 3, 2017

@bernd bernd self-assigned this Nov 3, 2017

@edmundoa edmundoa closed this in 4309698 Nov 3, 2017

edmundoa added a commit that referenced this issue Nov 3, 2017

Change data that is shown by the QuickValues histogram (#4312)
* Store a set of all terms in the terms histogram result

* Refactor SearchStore query manipulation functions

Create functions that do not mutate the global query string and let the
old functions use them.

This allows us to reuse the query manipulation functions without
changing the global query.

* Show regular QuickValues widget when changing the field

* Change data that is shown by the QuickValues histogram

Previously we showed the top/bottom N terms for every bucket in the
histogram. That was hard to visualize because every bucket could contain
completely different terms.

Now we changed the visualization to show *only* the top/bottom N terms from
the regular QuickValues widget projected over time.

Fixes #4291

* Improve QuickValues visualization for stacked values

Fixes #4309

(cherry picked from commit 4309698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment