Fix changing the default index set from the UI #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes changing the default index set from the UI work again. Fixes #4376
This can happen when the stats have not been loaded yet.
ghost
assigned 
edmundoa
pushed a commit
that referenced
this pull request
Nov 30, 2017
* Do not try to stop event propagation in MenuItem callback functions Makes changing the default index set from the UI work again. Fixes #4376 * Fix eslint errors * Let _formatStatsString handle undefined global stats This can happen when the stats have not been loaded yet. (cherry picked from commit 59e3607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4376
Note: This needs to be cherry-picked into the 2.4 branch