New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic graphs have wrong data type in overlay #4395

Closed
lennartkoopmann opened this Issue Dec 4, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@lennartkoopmann
Member

lennartkoopmann commented Dec 4, 2017

The new traffic graphs on the Cluster Overview page re-use the <TrafficGraph /> component but do not change the word "messages" in the hover overlay to "bytes":

screen shot 2017-12-04 at 12 48 08 pm

This should say "48,083,000 bytes", or, even better, "48.08 MB".

@lennartkoopmann lennartkoopmann added this to the 2.4.0 milestone Dec 4, 2017

@kroepke kroepke self-assigned this Dec 13, 2017

kroepke added a commit that referenced this issue Dec 13, 2017

allow to pass custom renderers for key and value titles in histograms
the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

@wafflebot wafflebot bot added the in progress label Dec 13, 2017

@wafflebot wafflebot bot removed the in progress label Dec 14, 2017

edmundoa added a commit that referenced this issue Dec 14, 2017

allow to pass custom renderers for key and value titles in histograms (
…#4418)

the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

edmundoa added a commit that referenced this issue Dec 14, 2017

allow to pass custom renderers for key and value titles in histograms (
…#4418)

the default renderers can now be replaced individually by setting props

used in TrafficGraphs to display nicer values

fixes #4395

(cherry picked from commit c73f55e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment