New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading example message on edit extractor page fails in large ES clusters #4553

Closed
edmundoa opened this Issue Feb 1, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Feb 1, 2018

Similar to the issue described (and fixed) in #4510, loading an example message in the edit extractor page may also fail in large ES clusters, as the search is not restricted.

Thank you @TheJCamping for reporting this issue! :)

Expected Behavior

Loading an example message to edit an extractor works and behaves consistently with loading a message through the RecentMessageLoader component that we use to create an extractor.

Current Behavior

Loading an example message to edit an extractor uses a search in all messages. Additionally it uses range instead of relative to set the timerange, so in 2.4 this would fail even if it was restricted.

Steps to Reproduce (for bugs)

  1. Create an extractor
  2. Edit the created extractor and see how we load a message in the background using a relative search in all messages

Your Environment

  • Graylog Version: Graylog-2.4.3, Graylog-3.0.0-SNAPSHOT(1717cdb)

@edmundoa edmundoa added the bug label Feb 1, 2018

@edmundoa edmundoa added this to the 2.4.4 milestone Feb 1, 2018

@edmundoa edmundoa self-assigned this Feb 1, 2018

edmundoa added a commit that referenced this issue Feb 1, 2018

Restrict search in edit extractor example
We recently fixed an issue in the RecentMessageLoader component to
ensure the search of an example is restricted to the last hour. This
change does the same for the edit extractor page.

Fixes #4553

@wafflebot wafflebot bot added the in progress label Feb 1, 2018

@bernd bernd closed this in #4554 Feb 2, 2018

bernd added a commit that referenced this issue Feb 2, 2018

Restrict search in edit extractor example (#4554)
We recently fixed an issue in the RecentMessageLoader component to
ensure the search of an example is restricted to the last hour. This
change does the same for the edit extractor page.

Fixes #4553

@wafflebot wafflebot bot removed the in progress label Feb 2, 2018

bernd added a commit that referenced this issue Feb 2, 2018

Restrict search in edit extractor example (#4554)
We recently fixed an issue in the RecentMessageLoader component to
ensure the search of an example is restricted to the last hour. This
change does the same for the edit extractor page.

Fixes #4553

(cherry picked from commit 4e89b70)

@wafflebot wafflebot bot assigned bernd Feb 2, 2018

edmundoa added a commit that referenced this issue Feb 5, 2018

Restrict search in edit extractor example (#4554) (#4559)
We recently fixed an issue in the RecentMessageLoader component to
ensure the search of an example is restricted to the last hour. This
change does the same for the edit extractor page.

Fixes #4553

(cherry picked from commit 4e89b70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment