New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for RestPermissions.LOOKUP_TABLES_READ #4861

Closed
1Jesper1 opened this Issue Jun 23, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@1Jesper1

1Jesper1 commented Jun 23, 2018

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Jun 25, 2018

Can you elaborate a bit why this check would be necessary? The resource in question is a stub for tests.

@1Jesper1

This comment has been minimized.

1Jesper1 commented Jun 25, 2018

Ah, thought the (live) service was used, so the permission check is needed as it's also used at

@no-response no-response bot removed the needs-input label Jun 25, 2018

@bernd bernd added this to the 3.0.0 milestone Jun 28, 2018

@bernd bernd self-assigned this Jun 28, 2018

@bernd

This comment has been minimized.

Member

bernd commented Jun 28, 2018

@1Jesper1 Thank you! The check is indeed missing here. This resource is used when editing a lookup table extractor.

bernd added a commit that referenced this issue Jun 28, 2018

dennisoelkers added a commit that referenced this issue Jun 28, 2018

Add missing permission checks (#4873)
* Add missing LOOKUP_TABLES_READ permission check

Fixes #4861

* Check permissions for recent log messages API endpoint

Fixes #4859

dennisoelkers added a commit that referenced this issue Jun 28, 2018

Add missing permission checks (#4873)
* Add missing LOOKUP_TABLES_READ permission check

Fixes #4861

* Check permissions for recent log messages API endpoint

Fixes #4859

bernd added a commit that referenced this issue Jun 28, 2018

Add missing permission checks (#4873) (#4878)
* Add missing LOOKUP_TABLES_READ permission check

Fixes #4861

* Check permissions for recent log messages API endpoint

Fixes #4859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment