Fix description and default value for Key and Value column #4973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix description and default value for Key and Value column
Description
graylog2-web-interface/src/components/lookup-tables/adapters/DSVHTTPAdapterFieldSet.jsx
Changed name in number in
help
description forgraylog2-server/src/main/java/org/graylog2/lookup/adapters/DSVHTTPDataAdapter.java
Changed default value in
public DSVHTTPDataAdapter.Config defaultConfiguration()
forMotivation and Context
Instead of CSVFileDataAdapter, which needs a name for the columns,
DSVHTTPAdapterFieldSet.jsx
adapter accepts only integer values, returning error in the case of strings.In
DSVHTTPDataAdapter.java
the default values 1 and 2 can cause misunderstandings. The right order of the columns starts from 0, not from 1.Screenshots (if appropriate):
Types of changes
Checklist: