New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content pack entity selection should support clicking on titles #5114

Closed
bernd opened this Issue Sep 14, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@bernd
Member

bernd commented Sep 14, 2018

Expected Behavior

When using the content pack creation wizard a click on an entity title or the section header (e.g. Grok Patterns) should trigger the selection.

image

Current Behavior

The user can only select entities by clicking the check box.

Your Environment

  • Graylog Version: 3.0.0-alpha.2-SNAPSHOT (rev 0dbe6f6)

@bernd bernd added this to the 3.0.0 milestone Sep 14, 2018

@kmerz kmerz self-assigned this Sep 25, 2018

kmerz added a commit that referenced this issue Sep 25, 2018

Make click on ExpandleListItem select checkbox
We do not have label and checkboxes, since we do not have
ids for the ExpandleListItem. There for I add an click
handler to the header which will click on the
associated checkbox.

Fixes #5114

@kmerz kmerz referenced this issue Sep 25, 2018

Merged

Fixes for content packs #5153

4 of 9 tasks complete

kmerz added a commit that referenced this issue Sep 25, 2018

Make click on ExpandleListItem select checkbox
We do not have label and checkboxes, since we do not have
ids for the ExpandleListItem. There for I add an click
handler to the header which will click on the
associated checkbox.

Fixes #5114

edmundoa added a commit that referenced this issue Oct 4, 2018

Fixes for content packs (#5153)
* Allign Install form fields

The install form has a list of entities
which were unallgined to the form fields.

Fixes #5115

* Fix closing of ContentPackEditParameter modal

the modal did not close since it was a child of
the open button. A click on the close button bubbled up
to the open button which would than reopen the closed
modal.

I moved out the modal as a child from the open button.

* Make click on ExpandleListItem select checkbox

We do not have label and checkboxes, since we do not have
ids for the ExpandleListItem. There for I add an click
handler to the header which will click on the
associated checkbox.

Fixes #5114

* Fix annotation from @edmundoa

Move click handler to its own named function to prevent
function createion leaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment