Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while running migration during 2.5 to 3.0 upgrade #5737

Closed
razvanphp opened this issue Feb 28, 2019 · 6 comments
Closed

Error while running migration during 2.5 to 3.0 upgrade #5737

razvanphp opened this issue Feb 28, 2019 · 6 comments

Comments

@razvanphp
Copy link
Contributor

@razvanphp razvanphp commented Feb 28, 2019

Expected Behavior

The dashboards should look the same after 3.0 upgrade.

Current Behavior

We get this error in the logs and the dashboards have huge widgets:

2019-02-28T13:49:03.346Z ERROR [ConfigurationManagementPeriodical] Error while running migration <V20180214093600_AdjustDashboardPositionToNewResolution{2018-02-14T09:36:00Z}>
java.lang.NullPointerException: null
	at org.graylog2.dashboards.DashboardImpl.getPositions(DashboardImpl.java:94) ~[graylog.jar:?]
	at org.graylog2.migrations.V20180214093600_AdjustDashboardPositionToNewResolution.upgrade(V20180214093600_AdjustDashboardPositionToNewResolution.java:69) ~[graylog.jar:?]
	at org.graylog2.periodical.ConfigurationManagementPeriodical.doRun(ConfigurationManagementPeriodical.java:43) [graylog.jar:?]
	at org.graylog2.plugin.periodical.Periodical.run(Periodical.java:77) [graylog.jar:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]

Steps to Reproduce (for bugs)

  1. Upgrade from 2.5 version to 3.0 while having dashboard widgets
  2. Check the server.log

Context

Your Environment

  • Graylog Version: 3.0.0+db6cf59
  • Elasticsearch Version: 5.5 (AWS)
  • MongoDB Version: v3.2.11
  • Operating System: Debian 9
  • Browser version: Chrome (latest)
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Mar 1, 2019

Hi @razvanphp,

We tested that migration internally before releasing 3.0 and didn't found any issues with it. Would you be so kind as to share with us the contents of the dashboards collection in the Graylog setup where you found the problem? Without more details is hard to tell what went wrong.

Thank you!

@razvanphp
Copy link
Contributor Author

@razvanphp razvanphp commented Mar 4, 2019

hey @edmundoa, I sent you the dump over email. Looking forward for a fix, upgrading production is on hold because of this. Thank you!

@kmerz
Copy link
Member

@kmerz kmerz commented Mar 6, 2019

@razvanphp could you add the dump to the issue instead? If there is a problem with that, could you send me the dump as well?

@razvanphp
Copy link
Contributor Author

@razvanphp razvanphp commented Mar 6, 2019

@kmerz forwarded, thanks!

@kmerz
Copy link
Member

@kmerz kmerz commented Mar 6, 2019

Thanks I found the rouge entry and will see what I can do!

kmerz added a commit that referenced this issue Mar 6, 2019
Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737
kmerz added a commit that referenced this issue Mar 6, 2019
Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737
dennisoelkers added a commit that referenced this issue Mar 12, 2019
* Fix AdjustDasbboardPostion Migration

Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737

* Add more dashboards to the test

Also: Fix annotations made by @dennisoelkers

* Fix error of maven licencs module

* Fix further annotations from @dennisoelkers
@razvanphp
Copy link
Contributor Author

@razvanphp razvanphp commented Mar 12, 2019

Is there anything we can do to manually fix this or we need to wait for the new version to be released to upgrade? Thank you for support!

kmerz added a commit that referenced this issue Mar 12, 2019
Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737
dennisoelkers added a commit that referenced this issue Mar 12, 2019
* Fix AdjustDasbboardPostion Migration

Prior to this change, the migration expected that all postions
have a "width", "heigth", "row" and "col" field.
Some users did not have a "width" or "height" field.

This change will add default values for the fields in the
getPositions functions of DashboardImpl.

Also fix some warnings.

Fixes #5737

* Add more dashboards to the test

Also: Fix annotations made by @dennisoelkers

* Fix error of maven licencs module

* Fix further annotations from @dennisoelkers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants