New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default value for email sender to empty value #5981
Conversation
The previous default (@example.org) is problematic for use cases where the email server rejects sender domains which are not validated / owned by the graylog server owners (e.g. amazon ses). In our use case users often forgot to empty the value and left the default in which resulted in notifications which where not sent out. With this change the default is empty and if I understand the code correctly the result would be that the default which is set in the server configuration should be used.
385b0cf
to
fe61a8e
Compare
Rebased to current master. |
@florianvolle is there anything I can do to get this into the next release? :) |
Hi @bjoernhaeuser, Thank you for creating this PR and for your patience while we looked into this! Here is a bit of information while I test your PR: We are working on a new alerting system, including new notifications, that will be released in Graylog 3.1. Since this change should also be done there, I created #6159 to be sure we don't forget. Feel free to add any missing information in case I missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned, an empty sender
will default to the transport_email_from_email
configuration option in the server config file. When that option is not set, an exception is thrown that is unfortunately not very clear on what went wrong.
Thinking about it, I think this is still better than the old behaviour, where the server set this example email address as sender and this all failed anyway.
Thanks <3 |
@bjoernhaeuser thank you for your contribution! 🎉 |
Description
The previous default (
@example.org
) is problematic for use cases wherethe email server rejects sender domains which are not validated / owned
by the graylog server owners (e.g. amazon ses).
In our use case users often forgot to empty the value and left the
default in which resulted in notifications which where not sent out.
With this change the default is empty and if I understand the code
correctly the result would be that the default which is set in the
server configuration should be used.
How Has This Been Tested?
Fired up a test instance and took a look at the empty field value.
Screenshots (if appropriate):
Sorry, did not take any :(
Types of changes
Checklist: