Skip to content

/graylog2-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single message page in search doesn't work with events #6142

Closed
bernd opened this issue Jul 15, 2019 · 0 comments · Fixed by #6156

Comments

@bernd
Copy link
Member

commented Jul 15, 2019

Expected Behavior

The single message view should be able to show events.

Current Behavior

When users click on the message ID in the search to go to the single message page, the page doesn't load:

image

Possible Solution

This is because events don't have the gl2_source_input field so loading the input title fails. The details view on the search page can handle this. I guess there are some missing checks to avoid loading the input data if the field is missing.

Steps to Reproduce (for bugs)

  1. Search in events stream
  2. Click on the ID of an event to get to the message page
  3. Checkout browser console

Your Environment

  • Graylog Version: 3.1.0-beta.1-SNAPSHOT

@bernd bernd added bug 3.1 Alerting - 3 release labels Jul 15, 2019

@bernd bernd added this to the 3.1.0 milestone Jul 15, 2019

dennisoelkers added a commit that referenced this issue Jul 17, 2019
@dennisoelkers
Fix rendering of events in single message view. 
Before this change, rendering a message generated by an event using the
`ShowMessagePage` component, e.g. using the `/messages/{index}/{id}`
endpoint failed, due to a missing source input id field in the event
message.

This change is fixing this and a couple of other issues with rendering
event messages.

Fixes #6142.
Verified
This commit was signed with a verified signature.
dennisoelkers Dennis Oelkers
GPG key ID: 440E58BD30A068C8 Learn about signing commits
Loading status checks…
19e3c33
@dennisoelkers dennisoelkers referenced this issue Jul 17, 2019
Merged
5 of 9 tasks complete

@bernd bernd closed this in #6156 Jul 18, 2019

bernd added a commit that referenced this issue Jul 18, 2019
@dennisoelkers @bernd
Fix rendering of events in single message view. (#6156) 
Before this change, rendering a message generated by an event using the
`ShowMessagePage` component, e.g. using the `/messages/{index}/{id}`
endpoint failed, due to a missing source input id field in the event
message.

This change is fixing this and a couple of other issues with rendering
event messages.

Fixes #6142.
b221c7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.1 Alerting - 3 release bug
Projects
None yet
Milestone
  3.1.0-legacy
1 participant
@bernd
You can’t perform that action at this time.